Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/financial#72 Add is_template field to contribution entity #15433

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Oct 7, 2019

Overview

Add is_template field to Contribution See https://lab.civicrm.org/dev/financial/issues/72

Before

Contribution does not have is_template field.

After

Contribution does have is_template field.

@civibot
Copy link

civibot bot commented Oct 7, 2019

(Standard links)

@civibot civibot bot added the master label Oct 7, 2019
@aydun
Copy link
Contributor Author

aydun commented Oct 7, 2019

@eileenmcnaughton - as the right id!

@aydun aydun changed the title Add is_template field to contribution entity dev/financial#72 Add is_template field to contribution entity Oct 7, 2019
@eileenmcnaughton
Copy link
Contributor

@aydun my only question here is around the title 'is a contribution template' - I just that's fine but perhaps we could add a description tag (which I think becomes a comment in mysql) to give more info about it being for recurring contribution use

@aydun aydun force-pushed the add_contribution_is_template branch from 23bd189 to dc39683 Compare October 8, 2019 09:21
@seamuslee001
Copy link
Contributor

Change looks fine, concept has been agreed to adding MOP

@eileenmcnaughton eileenmcnaughton merged commit 3662f7a into civicrm:master Oct 8, 2019
@aydun aydun deleted the add_contribution_is_template branch October 8, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants